Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the parser out of the way #2851

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Move the parser out of the way #2851

merged 2 commits into from
Aug 22, 2024

Conversation

privat
Copy link
Member

@privat privat commented Aug 20, 2024

Move the generated parser in a special file parser_sablecc.nit allowing parser.nit to be used as a group bottom module

Copy link

Test Results

    67 files     337 suites   17m 21s ⏱️
14 226 tests 13 682 ✅ 543 💤 0 ❌ 1 🔥
14 612 runs  14 053 ✅ 558 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 2f39c74.

@privat privat marked this pull request as ready for review August 21, 2024 01:44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For git blame reasons, we should probably git move the file. This seems to have interpreted to delete and have parser_sablecc.nit has a new file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a git move, github is just drunk

@privat privat changed the title Some parser work Move the parser out of the way Aug 22, 2024
@privat privat merged commit 5fa8f4c into nitlang:master Aug 22, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants